Conversation
tyrasd
approved these changes
Sep 22, 2025
69066ba to
0677b05
Compare
Collaborator
Author
|
conflicts resolved |
FloEdelmann
reviewed
Oct 24, 2025
ece96bf to
e1a2fc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
discarded.jsononly allows keys to be defined. This PR allows tags to be defined too.For example, some values of
attribution=*could be discardable, but not others.{ "created_by": true, "attribution": { "https://......import garbage.......": true } }it's a breaking change for any apps who use
discarded.json.this is required because openstreetmap/id-tagging-schema@a11968d is causing a weird inconsistency where iD is deleting some tags but not others (see this way's history)