Skip to content

Add validation for terms to be lowercase and sorted #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrasd merged 4 commits into from
Oct 21, 2025
Merged

Add validation for terms to be lowercase and sorted #243

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8d02ef
Add validation for terms to be lowercase and sorted
FloEdelmann Oct 14, 2025
954427a
sort terms in unit test
tyrasd Oct 21, 2025
9586d56
fix duplicates/sorting
tyrasd Oct 21, 2025
cb32c56
sort terms in unit test
FloEdelmann Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@
delete field.label;
}

validateTerms(field.terms, `field "${id}"`);
tstrings.fields[id].terms = Array.from(new Set(
(field.terms || [])
.map(t => t.toLowerCase().trim())
Expand Down Expand Up @@ -337,6 +338,7 @@
));
preset.aliases.forEach(a => names.add(a.toLowerCase()));

validateTerms(preset.terms, `preset "${id}"`);
preset.terms = Array.from(new Set(
(preset.terms || [])
.map(t => t.toLowerCase().trim())
Expand Down Expand Up @@ -854,7 +856,17 @@
process.stdout.write('Field "' + fields[fieldID].label + '" (' + fieldID + ') isn\'t used by any presets.\n');
}
}
}

function validateTerms(terms, where) {
if (!terms) return;

Check warning on line 863 in lib/build.js

View workflow job for this annotation

GitHub Actions / build (20) 

Trailing spaces not allowed
const expectedTerms = terms.map(term => term.toLowerCase().trim()).sort();
if (terms.every((term, index) => expectedTerms[index] === term)) return;

process.stderr.write(`Expected terms in ${where} to be lowercase and sorted alphabetically.`);
process.stdout.write('\n');
process.exit(1);
}

function validateDefaults(defaults, categories, presets) {
Expand Down
Loading
⚡