Insert suitable spec reference to RFC5280, where required#559
Open
yogeshbdeshpande wants to merge 4 commits intomainfrom
Open
Insert suitable spec reference to RFC5280, where required#559yogeshbdeshpande wants to merge 4 commits intomainfrom
yogeshbdeshpande wants to merge 4 commits intomainfrom
Conversation
yogeshbdeshpande
requested review from
henkbirkholz and
thomas-fossati
as code owners
Fixes #548 Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
yogeshbdeshpande
force-pushed
the
x.509-tidy-up
branch
from
17f4cfe to
a182072
Compare
|
The change you made to section 9.2.2.1 is good but I was expecting the reference to Section 6 of RFC5280 to replace the abbreviated rules noted here: https://datatracker.ietf.org/doc/html/draft-ietf-rats-corim-10#section-9.3.4.4. Is there a reason why abbreviated certificate validation rules are sufficient in 9.3.4.4? In my review, I noted the lack of a basic constraints check as potentially problematic. |
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Collaborator
Author
|
@carl-wallace , we agreed to refer it to Section 6 of RFC5280. Other types may require other validation rules, and is documented in the CoRIM Profile document by the Vendor. Changed the langauge to incorporate this.. |
|
Thank looks better. Thanks. |
steven-bellock
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #548