Fix Parsing Tagged Encrypted Data#21
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
============================================
+ Coverage 97.30% 97.34% +0.04%
- Complexity 84 86 +2
============================================
Files 22 22
Lines 260 264 +4
============================================
+ Hits 253 257 +4
Misses 7 7 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Replaced regex-based tag detection with a
substr()based method for parsing tagged encrypted data, improving handling of special characters and formatting.This fixes a bug where decryption was skipped due to special characters passed by base
Cipher.Related Issue
Resolves: #20
How Has This Been Tested?
The data was tested by encrypting and decrypting the base
Cipherbinary output.Checklist
Please confirm the following: