Skip to content

Fix Parsing Tagged Encrypted Data#21

Merged
ilicmiljan merged 1 commit into
mainfrom
fix-parsing-tagged-encrypted-data
Mar 16, 2024
Merged

Fix Parsing Tagged Encrypted Data#21
ilicmiljan merged 1 commit into
mainfrom
fix-parsing-tagged-encrypted-data

Conversation

@ilicmiljan

@ilicmiljan ilicmiljan commented Mar 16, 2024

Copy link
Copy Markdown
Owner

Description of Changes

Replaced regex-based tag detection with a substr() based method for parsing tagged encrypted data, improving handling of special characters and formatting.

This fixes a bug where decryption was skipped due to special characters passed by base Cipher.

Related Issue

Resolves: #20

How Has This Been Tested?

The data was tested by encrypting and decrypting the base Cipher binary output.

Checklist

Please confirm the following:

  • I have tested my changes and corrected any errors.
  • I have documented my changes if necessary.

@codecov

codecov Bot commented Mar 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (b80975b) to head (658e0b5).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #21      +/-   ##
============================================
+ Coverage     97.30%   97.34%   +0.04%     
- Complexity       84       86       +2     
============================================
  Files            22       22              
  Lines           260      264       +4     
============================================
+ Hits            253      257       +4     
  Misses            7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilicmiljan ilicmiljan merged commit ab7b561 into main Mar 16, 2024
@ilicmiljan ilicmiljan deleted the fix-parsing-tagged-encrypted-data branch March 16, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Special Character Handling in TagAwareCipher

1 participant