Conversation
wmurphyrd
left a comment
wmurphyrd
left a comment
There was a problem hiding this comment.
@dulce303 I absolutely love the design you added to immers-home, and the way you layered the border with box-shadow is really clever!
Need to review it on mobile as the new header font is larger and we lost some width from the border so the text content is taller, obscuring key scene content like the clickable vaporwave art and the avatar.
I've got some mobile styles here you could tweak: https://github.com/immers-space/immers-home/blob/main/src/index.css#L188
We could decrease the header font size and border thickness on mobile, and/or we could put a max-height and overflow-y: auto on .html3d to make these boxes scrollable where needed. What do you think?
There was a problem hiding this comment.
Whoops looks like you need to update your Node version to at least 16 as this has downgraded our package-lock to an older version
| "@testing-library/react": "^12.1.3", | ||
| "@testing-library/user-event": "^13.5.0", | ||
| "classnames": "^2.3.1", | ||
| "gltfpack": "^0.18.0", |
There was a problem hiding this comment.
This version of gltfpack doesn't include the texture compression, instead we have to download it manually from https://github.com/zeux/meshoptimizer/releases
| <AtWaypoint waypoints={waypoints} i={0} height={1.2} offset={-5} before={0} after={0.79} /> | ||
| <AtWaypoint waypoints={waypoints} i={1} height={1.2} offset={2} before={0.11} after={0.35} portal2D={portal2D} | ||
| heading='Boutique 3D Web development with a purpose'> | ||
| heading='Boutique 3D Web development with <br> a purpose'> |
There was a problem hiding this comment.
We could change heading is used in AtWaypoint to allow HTML, but do we really want that break here?
| box-shadow: | ||
| 0 0 0 10px white, | ||
| 0 0 0 15px #000066; |
There was a problem hiding this comment.
This is so clever - love it
|
|
||
| #root h1 { | ||
| font-family: 'AlegreyaSansSC', sans-serif; | ||
| font-family: 'PressStart2P-Regular', sans-serif; |
There was a problem hiding this comment.
I'm wondering if, for this title, we keep Alegreya so it's consistent with other branding. OR should we be moving all the Immers Space branding to PressStart2P?
2 participants
No description provided.