Conversation
danieldietzler
approved these changes
Sep 15, 2025
Member
There was a problem hiding this comment.
This breaks the github higlighting. Does vscode automatically pick up that it's still a Dockerfile?
Member
Author
There was a problem hiding this comment.
I'm not sure. You can always manually configure it though
Member
There was a problem hiding this comment.
I believe calling it dev.Dockerfile should fix the highlighting
Member
Author
There was a problem hiding this comment.
It looks like VS Code highlighting works fine for both conventions. Having the file named dev.Dockerfile right next to Dockerfile looks really weird to me though. I think I prefer Dockerfile.dev (next to Dockerfile), so I'll keep it as is for now at least.
jrasm91
force-pushed
the
chore/split-dockerfile
branch
from
09a41c7 to
e6433e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out the development related Dockerfile sections, since it's completely separate from the production build.