Skip to content

[patch] use resolve instead of builtin-modules#1069

Merged
ljharb merged 1 commit intoimport-js:masterfrom
ljharb:resolve
Apr 7, 2018
Merged

[patch] use resolve instead of builtin-modules#1069
ljharb merged 1 commit intoimport-js:masterfrom
ljharb:resolve

Conversation

@ljharb
Copy link
Copy Markdown
Member

@ljharb ljharb commented Apr 7, 2018

resolve has a much more thorough list of builtins, and since I maintain it, we can keep it updated more easily than with builtin-modules.

@ljharb ljharb requested review from benmosher and jfmengels April 7, 2018 20:36
@ljharb
Copy link
Copy Markdown
Member Author

ljharb commented Apr 7, 2018

Absent objections, I'm going to merge this once tests pass.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 7, 2018

Coverage Status

Coverage remained the same at 96.47% when pulling fb8e1e5 on ljharb:resolve into d8077c8 on benmosher:master.

@ljharb
Copy link
Copy Markdown
Member Author

ljharb commented Apr 7, 2018

appveyor failure is a fluke.

@ljharb ljharb merged commit f0b4f3e into import-js:master Apr 7, 2018
@ljharb ljharb deleted the resolve branch April 7, 2018 21:27
Copy link
Copy Markdown
Member

@benmosher benmosher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants