feat: add Step 8.5 PRE-PR CODE REVIEW to maestro#16
Open
vs-praveen-chittem wants to merge 1 commit intomainfrom
Open
feat: add Step 8.5 PRE-PR CODE REVIEW to maestro#16vs-praveen-chittem wants to merge 1 commit intomainfrom
vs-praveen-chittem wants to merge 1 commit intomainfrom
Conversation
Closes the gap between local correctness gates (Step 8 VERIFY) and the external PR review polling loop (Step 10). Runs code-reviewer (and security-reviewer when the diff touches sensitive code, plus any language-specific reviewers) in parallel against the local diff before the PR is opened, blocking on CRITICAL and HIGH findings. Skip rule: trivial config/docs changes bypass the step. Bug fixes do not bypass it. Bumps plugin to 1.7.2 and adds the pre-pr-review keyword.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-reviewer(always),security-reviewer(when the diff touches auth/input/DB/LLM/secrets), and any installed language-specific reviewers in parallel against the local diffpre-pr-reviewkeywordWhy
Maestro's Step 10 only fires AFTER the PR is open and runs against the merged-base diff. Nothing previously enforced a local diff review BEFORE push. The user's CLAUDE.md rule "code review BEFORE PR creation" was relying on memory rather than the workflow itself. Step 8.5 makes it explicit and saves a full claude-review bot cycle on every PR.
Why a separate step (not folded into Step 8 or Step 10)
Step 8 VERIFY enforces correctness (tests, types, lint). Step 10 REVIEW is post-PR external review. Step 8.5 owns the local pre-push window where a focused diff review prevents predictable bot rework. Single-purpose steps stay readable.
Test plan
skills/maestro/SKILL.mdend to end and confirm flow diagram, skip table, and Step 8.5 section all render correctly in markdown8.5digit alignment under8in the flow diagramplugin.jsonis valid JSON and version is 1.7.2Trade-offs acknowledged
Adds one parallel agent dispatch on every non-trivial task before commit. That latency is the cost of catching issues locally instead of burning a claude-review bot cycle. Trivial changes are unaffected via the skip rule.