Skip to content

Support Chinese in impressConsole#774

Merged
henrikingo merged 2 commits intoimpress:masterfrom
kdxcxs:patch-1
Oct 11, 2020
Merged

Support Chinese in impressConsole#774
henrikingo merged 2 commits intoimpress:masterfrom
kdxcxs:patch-1

Conversation

@kdxcxs
Copy link
Copy Markdown
Contributor

@kdxcxs kdxcxs commented Oct 10, 2020

No description provided.

@henrikingo
Copy link
Copy Markdown
Member

henrikingo commented Oct 10, 2020

Why not all three?

case zh:
case zh-cn:
case zh-CN:
    ...

@kdxcxs
Copy link
Copy Markdown
Contributor Author

kdxcxs commented Oct 10, 2020

Cause it's just simplified Chinese,considering the existence of traditional Chinese,I think it's better like that.

@henrikingo henrikingo merged commit d0c427f into impress:master Oct 11, 2020
@henrikingo
Copy link
Copy Markdown
Member

henrikingo commented Oct 11, 2020

Thanks. This is a cool addition of a major language!

@kdxcxs
Copy link
Copy Markdown
Contributor Author

kdxcxs commented Oct 11, 2020

My pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kdxcxs @henrikingo
⚡