Verify tgmpa fix

[DavidWells]

Please verify this fix on your live site: fa462dd

Latest code should have everything replaced into a new class(es)

[jrfnl]

Uh oh... sorry to butt in... one of the TGMPA devs here. May I ask what you are trying to achieve here ?

The way TGMPA is set up - by design - , it can be used by themes and plugins at the same time and will gather all the dependency information from the various sources in just one screen. With the changes you seem to be making now, you are breaking that design and the end-user could end up with several TGMPA screens, several TGMPA notices on the admin pages and totally confused... 😿

We've seen one issue on the fatal error notice during the testing period and that turned out to be an incomplete/corrupted download, not an issue with the TGMPA library itself.

[DavidWells]

We updated the class like you suggested and it caused fatal errors across a wide number of users that had themes or plugins using an older version of the class.

A.k.a the class is currently not stable to use without forking it to our needs.

Yes the user will have 2 notification boxes if another theme/plugin uses TGMPA but there will not be any fatal errors.

We prefer the non fatal error route.

In the future, we plan on using the non forked version but need to be sure that its forward and backwards compatible.

[DavidWells]

@jrfnl this was one of the errors with 2 conflicting versions of the class:

Fatal error: Call to undefined method TGM_Utils::validate_bool() in /home/hatnohat/hudsonatwell.co/wp-content/plugins/landing-pages6/libraries/class-tgm-plugin-activation.php

Here was another: http://support.inboundnow.com/support/topic/trouble-accessing-the-admin/ "Fatal error: Call to protected TGM_Plugin_Activation::__construct() from invalid context in...(theme class) "

[jrfnl]

@DavidWells Thanks for your response.

Fatal error: Call to undefined method TGM_Utils::validate_bool() in /home/hatnohat/hudsonatwell.co/wp-content/plugins/landing-pages6/libraries/class-tgm-plugin-activation.php

This really indicates a corrupted download package. The TGM_Utils class was introduced in v 2.5.0 and is only called from code in v 2.5.0. All that code is in one file, so the only reason the class cannot be found can be a corrupted package. (TGMPA/#421)

The only other thing I can think of is a completely different package also using the class name TGM_Utils, though that should be easy enough to find out if the user shares details about installed themes and plugins.
Would be a bit weird though... I've send a message to @thomasgriffin checking if he knows of any.

Gosh.. how I miss being able to use namespaces....

Anyway, if we would get confirmation that another theme/plugin/library is using that class name, we'll happily change the class name and release v 2.5.1 asap.

"Fatal error: Call to protected TGM_Plugin_Activation::__construct() from invalid context in...(theme class) "

That is one we are also aware off (TGMPA/#391) and the constructor method was made private by design. This one happens when v 2.5.0 has been loaded in and another plugin or theme tries to load TGMPA <= 2.3.6 after that.
v 2.3.6 was released over three years ago and should most definitely not be used anymore. Unfortunately it seems it still is, more than we'd like to see.

This one is the reason why we've been trying to reach out to theme and plugin devs urging them to upgrade.

[jrfnl]

@DavidWells FYI - just did a quick search on the class name and to my dismay found another prominent WP plugin using the same classname. Mea Culpa.
Just send in PR TGMPA/#446 for immediate release to fix that.

[DavidWells]

We are all for using the unaltered class.

We will revisit it in like 6months to see if compatibility is stable out in the wild.

Thanks for your guys work on the class. It's super nifty.

[jrfnl]

@DavidWells In six months time (well maybe a little longer), we hope to have abolished the need for the class: https://make.wordpress.org/core/2015/07/10/feature-plugin-chat-on-july-14/#comment-26310

[jrfnl]

@DavidWells Just one last question - can you give me some idea how many users is "across a wide number of users" ?
Even though I don't think it is the right way to go, I will discuss making the constructor public again - for the time being - to prevent that second fatal. That would eliminate your issues for now.

[DavidWells]

We had 5 reports and then pulled our latest push to stop the issue.

From what I can tell, it was a fatal for everyone not using the very very
latest 2.5.0 version of your class.

So I'd imagine the problem is going to be pretty widespread

On Mon, Jul 13, 2015 at 3:02 PM, Juliette notifications@github.com wrote:

@DavidWells https://github.com/DavidWells Just one last question - can
you give me some idea how many users is "across a wide number of users" ?
Even though I don't think it is the right way to go, I will discuss making
the constructor public again - for the time being - to prevent that second
fatal. That would eliminate your issues for now.

—
Reply to this email directly or view it on GitHub
#178 (comment)
.

[jrfnl]

Thanks for the reply.

FYI - The fatal will only occur if:
a) there is another theme/plugin also using TGMPA and
b) that one is loaded after TGMPA 2.5.0 has already been loaded (mu-plugins -> plugins -> themes)
b) that theme/plugin includes TGMPA <= 2.3.6.

There should be no problem whatsoever with TGMPA 2.4.0+ as long as people have implemented following the example.
We can't speak for non-standard implementations.

[jrfnl]

Will let you know if we decide to revert the making private of the constructor.

[jrfnl]

@DavidWells We've decided to revert the protected constructor.
I've also done some more incompatibility hunting and have just opened TGMPA/PR #448 to fix it all.

I expect TGMPA 2.5.2 to be released today or tomorrow and I expect you should be ok to use the unaltered TGMPA again after that.