Merged
Conversation
felipesabino
requested review from
marcelorisse,
thiago-soliveira and
tibawatanabe
| import 'reflect-metadata'; | ||
|
|
||
| import * as D from './decorator'; | ||
| import * as DD from './decorator/'; |
There was a problem hiding this comment.
I fell a little bit uneasy with these "duplicated" decorators
Author
There was a problem hiding this comment.
managed to expose everything from inside the old decorator.ts file, guess it is better like that while all the other decorators are in the old structure.
| /** | ||
| * Arguments for a Union type on graphql schema | ||
| */ | ||
| export interface UnionOpton<T> { |
| .filter(_ => _), //filter null values | ||
| }); | ||
| }) | ||
| .find((_, index) => index === 0) || null; |
There was a problem hiding this comment.
What is the purpose of this || null?
Author
There was a problem hiding this comment.
just to be explicit in the return type instead of returning undefined. I actually could have set the function return type to be graphql.GraphQLUnionType | undefined instead 👍
marcelorisse
approved these changes
Oct 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Union TypedecoratorReflectin favor to a well defined interface (metadata storage) for metadatas (inspired by [class-validator(https://github.com/pleerock/class-validator)] androuting-controllersstyle)