Feature - Refactoring @Field decorator#34
Conversation
felipesabino
force-pushed
the
feature/refactor-field
branch
from
d49d5b5 to
25b3235
Compare
felipesabino
changed the title
felipesabino
changed the title
tibawatanabe
left a comment
tibawatanabe
left a comment
There was a problem hiding this comment.
2 comments:
- I think there are some unneeded imports of
reflect-metadata ArgumentArg... a little bit strange but I have no better suggestion
| @@ -0,0 +1,27 @@ | |||
| import 'reflect-metadata'; | |||
There was a problem hiding this comment.
Do we need this here? I'm not finding a need...
There was a problem hiding this comment.
I think there are some unneeded imports of reflect-metadata
I was getting a lot of error like
Uncaught TypeError: Reflect.getMetadata is not a function
So this helped me suppress it... found this solution here but do not know a better alternative.
Do you know the root cause for it? Any idea if something at tsconfig might fix this issue without these imports?
ArgumentArg... a little bit strange but I have no better suggestion
Same here 😞
There was a problem hiding this comment.
I think there are some unneeded imports of reflect-metadata
Ok, I did some reading and I need it just in my app/lib entry point, so I added it to both index.ts and *.spec.ts
3 participants
Sorry but this will be a big PR with a lot of breaking changes
@Fielddecorator and nested dependencies (@Arg,@OrderBy,@Root,@Beforeand@Ctx) - Refactor decorators class structure #22DefaultOption,DefaultMetadataandDefaultArginterfaces to justOption,MetadataandArgumentinstead as in Feature - Refactoring more decorators #32 (comment)MetadataBuilderinstead ofReflect)field_type_factoryto handle metadata properly and to be less verbose/confusingTODOs for possible missing tests@Pagination@Description@List@NonNull