Skip to content

Remove wrong && #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
askmon merged 3 commits into from
Dec 22, 2017
Merged

Remove wrong && #60

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6124fe5
Remove wrong &&
askmon Dec 21, 2017
5b8d53b
update changelog
askmon Dec 21, 2017
f7d983d
Fix pr order
askmon Dec 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## master

- Removed wrong comparison on description - [#60](https://github.com/indigotech/graphql-schema-decorator/pull/60) - [@askmon](https://github.com/askmon)
Copy link
Copy Markdown

@marcelorisse marcelorisse Dec 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ordered from oldest to newest.

- Added functional tests (to make sure resolvers are working properly) - [#34](https://github.com/indigotech/graphql-schema-decorator/pull/34) - [@felipesabino](https://github.com/felipesabino)
- Review JSDoc for each decorator and its option argument - [#34](https://github.com/indigotech/graphql-schema-decorator/pull/34) - [@felipesabino](https://github.com/felipesabino)
- Updated examples - [#34](https://github.com/indigotech/graphql-schema-decorator/pull/34) - [@felipesabino](https://github.com/felipesabino)
Expand Down
2 changes: 1 addition & 1 deletion src/type-factory/order-by.type-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export class OrderByTypeFactory {
let valuesDict: { [name: string]: any; } = {};
values.forEach((value: any) => {
valuesDict[value.name] = {
description: value.description && value.description,
description: value.description,
};
});
return new GraphQLEnumType({
Expand Down
⚡