Allow circular references#68
Merged
tibawatanabe merged 2 commits intoindigotech:masterfrom May 19, 2018
Merged
Conversation
felipesabino
approved these changes
Jan 5, 2018
| } | ||
|
|
||
| const fields = fieldMetadataList.reduce((map, fieldMetadata) => { | ||
| const fields = () => fieldMetadataList.reduce((map, fieldMetadata) => { |
There was a problem hiding this comment.
🤔 clever 👏
I will leave this SO answer here for future reference on why this works https://stackoverflow.com/a/39290345/429521
|
Could you add an entry with you name and the change description to the CHANGELOG.md file before I merge? |
|
Any update the status of this PR? I see there's another PR for the same issue opened 6 days ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #64; fix #65
It adds ability to specify type as a thunk as can be seen here: https://github.com/Cactucs/graphql-schema-decorator/blob/6ace1fb78883362ecfab87070a7a38c8b232daea/src/specs/object.type-factory.spec.ts#L84