chore(ci): update to handle release tags#26166
Merged
Conversation
bbf6d0a to
10075ee
Compare
praveen-influx
approved these changes
Mar 19, 2025
Contributor
praveen-influx
left a comment
There was a problem hiding this comment.
LGTM - thanks for the detailed docs, this probably needs to be linked to README so that it's easier to find this info but I can do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates:
.circleci/packages/config.yamlto add a stricter regex for release images that conforms to https://github.com/influxdata/influxdb_pro/pull/606#issuecomment-2734361619 with documentation.circleci/config.ymlto use the latest ci-support images (to fix an issue withv3.0.0and deb packages observed in preparing this PR).circleci/config.ymlto update release_filter (a looser regex than.circleci/packages/config.yamlfor easier maintenance;.circleci/packages/config.yamlneeds to be the most precise version so it can create packages correctly) and add some documentation on how to set tags (based on and referring to.circleci/packages/config.yaml)The
.circleci/packages/config.yamlupdates were verified by running the updatedci-supportlocally. The regexes were verified by creating a test script and running it.Details
Eg:
Note, I did NOT test this with by pushing a conforming tag.