feat(influxdb3_server): include node_id label on exported metrics#27402
Open
o6ivp wants to merge 1 commit intoinfluxdata:mainfrom
Open
feat(influxdb3_server): include node_id label on exported metrics#27402o6ivp wants to merge 1 commit intoinfluxdata:mainfrom
o6ivp wants to merge 1 commit intoinfluxdata:mainfrom
Conversation
Add `with_default_attributes` to `PrometheusTextEncoder` so the same label set can be applied to every reported observation. `handle_metrics` uses it to attach `node_id` to each series, sparing operators from relabeling on hostname. `node_modes` is more relevant to Enterprise and is left for a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #26873
Add a
with_default_attributesbuilder toPrometheusTextEncoderand use it to attachnode_idto every series exposed via/metrics. As the issue notes,node_modesis more relevant to Enterprise and is left for a follow-up.