Skip to content

Commit 22de173

Browse files
committed
Fix documentsctrl test
1 parent c3e3160 commit 22de173

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

server/src/test/kotlin/org/ivdnt/galahad/util/SpringUtil.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ object UserHeader {
2929
}
3030
object SpringUtil {
3131
fun createCorpus(config: Config): Corpus {
32-
val workdir = config.getWorkingDirectory().resolve("corpora").resolve("custom")
32+
val workdir = config.getWorkingDirectory().resolve("corpora").resolve("user")
3333
return TestUtil.createCorpus(workdir)
3434
}
3535
}

server/src/test/kotlin/org/ivdnt/galahad/util/TestUtil.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ object TestUtil {
4646
val parent = workdir ?: createTempDirectory().toFile()
4747
val corpora = Corpora(parent)
4848
val meta = MutableCorpusMetadata(
49-
"you",
49+
"testUser",
5050
"testCorpus",
5151
1200,
5252
1300,

server/src/test/kotlin/org/ivdnt/galahad/web/DocumentsControllerTest.kt

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import org.ivdnt.galahad.app.Config
44
import org.ivdnt.galahad.app.Galahad
55
import org.ivdnt.galahad.corpora.Corpus
66
import org.ivdnt.galahad.documents.DocumentMetadata
7+
import org.ivdnt.galahad.exceptions.DocumentInvalidException
78
import org.ivdnt.galahad.util.JSON
89
import org.ivdnt.galahad.util.SpringUtil
910
import org.ivdnt.galahad.util.TestConfig
@@ -39,7 +40,7 @@ class DocumentsControllerTest(
3940
val corpus = SpringUtil.createCorpus(config)
4041

4142
// list files in directory
42-
val dir: File = TestUtil.get("all-formats/input")
43+
val dir: File = TestUtil.get("formats/shared/converter")
4344
for (file in dir.listFiles()) {
4445
// skip layer pie-tdn.tsv
4546
if (file.name != "pie-tdn.tsv") {
@@ -52,9 +53,9 @@ class DocumentsControllerTest(
5253
val doc = getDocs(corpus)[0]
5354
val uuid = corpus.immutableMetadata.uuid
5455
val result: MvcResult = mvc.perform(
55-
MockMvcRequestBuilders.get("/corpora/$uuid/documents/${doc.name}/raw").headers(UserHeader.get())
56+
MockMvcRequestBuilders.get("/corpora/$uuid/documents/${doc.name}/download").headers(UserHeader.get())
5657
).andReturn()
57-
assertEquals(TestUtil.get("all-formats/input/${doc.name}").readText(), result.response.contentAsString)
58+
assertEquals(TestUtil.get("formats/shared/converter/${doc.name}").readText(), result.response.contentAsString)
5859
// Delete a doc
5960
mvc.perform(
6061
MockMvcRequestBuilders.delete("/corpora/$uuid/documents/${doc.name}").headers(UserHeader.get())
@@ -89,7 +90,8 @@ class DocumentsControllerTest(
8990
fun `Upload invalid file`() {
9091
val corpus = SpringUtil.createCorpus(config)
9192
val file = TestUtil.get("documents/invalid-root.xml")
92-
assertThrows(Exception::class.java){ mvc.uploadFile(file, corpus, MediaType.APPLICATION_XML_VALUE) }
93+
val res = mvc.uploadFile(file, corpus, MediaType.APPLICATION_XML_VALUE)
94+
assertEquals(res.resolvedException::class, DocumentInvalidException::class)
9395
}
9496

9597
private fun getDocs(corpus: Corpus): List<DocumentMetadata> {

0 commit comments

Comments
 (0)