Fix docutils deprecation and main_menu is_active rendering#714
Merged
Conversation
Replace deprecated docutils.frontend.OptionParser with get_default_settings(). Override iommi_open_tag in BoundM to set is_active class before delegating to Tag.iommi_open_tag().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docutils.frontend.OptionParserwithget_default_settings()— fixesDeprecationWarningthat was causing anINTERNALERRORin pytestiommi_open_taginBoundMto set theis_activeCSS class before delegating tosuper().iommi_open_tag()— fixes missingis_activeclass on menu items after theTagbase class changeTest plan
pytest iommi/main_menu__tests.pypasses (22/22)INTERNALERROR