feat(fab-button): add close button icon property#19626
Merged
brandyscarney merged 7 commits intoionic-team:masterfrom Jun 8, 2020
Merged
feat(fab-button): add close button icon property#19626brandyscarney merged 7 commits intoionic-team:masterfrom
brandyscarney merged 7 commits intoionic-team:masterfrom
Conversation
ionitron-bot
bot
added
package: angular
brandyscarney
approved these changes
Jun 8, 2020
liamdebeasi
approved these changes
Jun 8, 2020
Member
|
Thank you for the PR, this is great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When a
ion-fabis used with a list inside it. If you activate it, then acloseicon appears inside theion-fab-buttonthat cannot be changed.What is the new behavior?
This PR exposes a new property to be able to change the icon shown when fab is activated. Defaults to the previous one:
close.Does this introduce a breaking change?
Other information