Skip to content

feat(all): add support for configuring animations on a per-page basis #21433

Merged
liamdebeasi merged 17 commits intomasterfrom
per-page-anim
Jun 8, 2020
Merged

feat(all): add support for configuring animations on a per-page basis #21433
liamdebeasi merged 17 commits intomasterfrom
per-page-anim

Conversation

@liamdebeasi
Copy link
Copy Markdown
Contributor

@liamdebeasi liamdebeasi commented Jun 4, 2020 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #18209

What is the new behavior?

  • Adds support for Angular and Core

This does not add support for Ionic React. Support for this will ship whenever the new Ionic React refactor ships. See https://github.com/ionic-team/ionic/tree/per-page-anim-react.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added package: angular @ionic/angular package package: core @ionic/core package labels Jun 4, 2020
@liamdebeasi liamdebeasi marked this pull request as ready for review June 4, 2020 18:52
@liamdebeasi liamdebeasi changed the title feat(angular): add support for configuring animations on a per-page basis feat(all): add support for configuring animations on a per-page basis Jun 8, 2020
brandyscarney
brandyscarney reviewed Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Should it be added to nav-link or is it only for components that use openURL? I ask because nav-link has a routerDirection prop.

Comment thread core/src/components/back-button/back-button.tsx Outdated
Comment thread core/src/components/router/router.tsx Outdated
liamdebeasi and others added 3 commits June 8, 2020 12:26
@liamdebeasi @brandyscarney
Update core/src/components/router/router.tsx
93e8b9e 
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi
fix comment
6f396ce
@liamdebeasi
Add routeranimation to nav-link
2d5170c
@liamdebeasi liamdebeasi merged commit f34d375 into master Jun 8, 2020
@liamdebeasi liamdebeasi deleted the per-page-anim branch June 8, 2020 19:49
@liamdebeasi liamdebeasi mentioned this pull request Jun 8, 2020
Closed
@eun-choi eun-choi mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@mhartington mhartington Awaiting requested review from mhartington

@manucorporat manucorporat Awaiting requested review from manucorporat

Assignees

No one assigned

Labels

package: angular @ionic/angular package package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Per page animation configurability

2 participants

@liamdebeasi @brandyscarney
⚡