fix: pass backwards-compatible level-js options#215
Merged
Conversation
Hm, this was actually intended to maintain backwards compatibility. Because before
In addition, |
Merged
Member
Author
|
@jacobheun if you're happy with this could you please release it & backport it to 0.29.x so we can do a patch release for ipfs@0.39.0 and fix ipfs/js-ipfs#2629? |
achingbrain
added a commit
that referenced
this pull request
Nov 29, 2019
* fix: pass backwards-compatible level-js options * fix: fix options test * fix: configure datastore prefix and get right level version
achingbrain
added a commit
that referenced
this pull request
Nov 29, 2019
* fix: pass backwards-compatible level-js options * fix: fix options test * fix: configure datastore prefix and get right level version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between
level-js@2andlevel-js@4it started passing version numbers intoindexedDB.openso we have to specify these now. It also prefixes locations with a disambiguator, which we need to set to blank for browsers to still be able to read their previously created databases.Depends on:
[ ] chore: update deps #217