Importer with empty source should fail with wrap with directory?

[vasco-santos]

When using a wrapWithDirectory: false, nothing will be yielded from the unixfs importer when providing an empty import candidate. However, when wrapWithDirectory: true the empty directory is returned.

Is this the expected behaviour?

import normalizeAddInput from 'ipfs-core-utils/src/files/normalise-input/index.js'
import { importer } from 'ipfs-unixfs-importer'

const input = []

const rootEntry = await last(pipe(
    normalizeAddInput(input),
    (source: any) => importer(source, blockstore, {
      cidVersion: 1,
      chunker: 'fixed',
      maxChunkSize: 262144,
      hasher: sha256,
      rawLeaves: true,
      wrapWithDirectory: true
    })
  ))

[rvagg]

This doesn't seem unreasonable behaviour to me - you're essentially switching between "wrapping this nothing in nothing yields nothing " and "wrapping this nothing in something yields something".

Do you think it should error? Or the wrapped version to return nothing? Seems like a squishy edge case where the behaviour just needs to be well defined and documented.

[vasco-santos]

Initially, I was expecting this to error, or at least not yield anything.

But, perhaps we should allow to wrap nothing with a directory 🤷🏼 I agree that we just need to be well defined and documented. I am ok with this behaviour if we document it