[code_prettify] added support for IPython magics, cf #1018#1019
Merged
jfbercher merged 2 commits intoipython-contrib:masterfrom Jul 14, 2017
Merged
[code_prettify] added support for IPython magics, cf #1018#1019jfbercher merged 2 commits intoipython-contrib:masterfrom
jfbercher merged 2 commits intoipython-contrib:masterfrom
Conversation
|
Thanks, this PR works well for me. |
Contributor
|
I noticed that Would it be a good idea to add this to the KernelExecOnCells library somehow? I guess we don't want kernel specific code in there, but handling cell magics is a problem any python extension will face when using the library. I guess the best thing would be to write some js code that handles cell magics so it works for all kernels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support IPython magics in python code cells, a function
yapf_reformatis defined and automatically loaded at initialization as a library. This function takes care of commenting magics before reformatting and uncommenting them after. This should fix #1018.