[ExecuteTime] menu items & options for clearing timing data#1022
Merged
jcb91 merged 5 commits intoipython-contrib:masterfrom Jul 21, 2017
Merged
[ExecuteTime] menu items & options for clearing timing data#1022jcb91 merged 5 commits intoipython-contrib:masterfrom
jcb91 merged 5 commits intoipython-contrib:masterfrom
Conversation
* Fix the toggle visibility, which was returning too early :/ * Don't prevent click-event propagation, as otherwise it prevents the menu from closing. * add href to submenu to get correct cursor. Add click handler to prevent following the href :P
wstomv
approved these changes
Jul 19, 2017
wstomv
left a comment
wstomv
left a comment
There was a problem hiding this comment.
I have tried various (but not all) combinations of option settings and menu commands. They all seem to work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1021 (hopefully)
Provides menu items to clear selected/all cells' timing data, along with configurable options to clear timings on kernel restart and/ot when a cell's outputs are cleared.