[various] use Jupyter.notebook.config instance, where appropriate#1061
Merged
jcb91 merged 1 commit intoipython-contrib:masterfrom Aug 26, 2017
Merged
[various] use Jupyter.notebook.config instance, where appropriate#1061jcb91 merged 1 commit intoipython-contrib:masterfrom
jcb91 merged 1 commit intoipython-contrib:masterfrom
Conversation
to avoid reloading (from server!) the same config file for each nbextension. In most cases this also means we don't need to require the 'services/config' module any longer.
Member
Author
|
This may break a few things if I've not understood the loading mechanisms for all affected nbextensions, but I'm going to merge now, then wait for bugs :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid reloading (from server!) the same config file for each nbextension.
In most cases this also means we don't need to require the 'services/config' module any longer.