[various] ensure actions have names and prefixes, and buttons keep correct ids#1123
Merged
jcb91 merged 4 commits intoipython-contrib:masterfrom Oct 13, 2017
Merged
[various] ensure actions have names and prefixes, and buttons keep correct ids#1123jcb91 merged 4 commits intoipython-contrib:masterfrom
jcb91 merged 4 commits intoipython-contrib:masterfrom
Conversation
Member
Author
|
I'm going to go ahead and merge this, hoping that it doesn't break anything (on the basis that it adds no extra jshint errors 🤣). As always, open issues as required if it turns out I have broken something! |
This was referenced Oct 16, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially an update on top of #1103, adding changes mentioned in #1103 (comment)