[runtools] don't alter selection when running cells#1145
Merged
jcb91 merged 3 commits intoipython-contrib:masterfrom Nov 4, 2017
Merged
[runtools] don't alter selection when running cells#1145jcb91 merged 3 commits intoipython-contrib:masterfrom
jcb91 merged 3 commits intoipython-contrib:masterfrom
Conversation
* don't loop twice in initialization * find cell applying to CodeMirror instance using $().closest rather than looping * use setCells function to simplify marked toggling functions * use is_marked function over duplicating code * use cells.length over notebook.ncells, which calls get_cells again * don't use notebook.get_cell (which gets all cells first, internally) when we already have a list of cells * use function for showing/hiding marked cells' inputs/outputs, rather than duplicating
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1126
Also makes a bunch of simplifications/efficiency improvements to runtools.