Remove lxml >=3.8.0 dependency.#1174
Conversation
The version dependency makes it hard to install nbextensions on certain platforms (e.g. ARM). See Issue ipython-contrib#1172.
|
PR attempting to fix #1172. |
|
Travis is happy, so this looks good to me. On a side note: I am using berryconda on Arm, so I did not run into this problem. It provides all nice scientific Python packages in a recent version. You get lxml version 4.1.1 there. |
This allows nbconvert_support to import the module, even if lxml is missing or has missing dependency libs, etc. In this way, problems with lxml should only bother people who are actually tryying to use this.
|
Well, Travis is happy because it installs lxml 4.1.1, so this PR doesn't change that 😆. However, I did test lxml down to 3.4 at least with tests running ok. I thought maybe we should keep major-version dependency for compatibility reasons (so |
|
@jcb91 Thanks for doing the extra work of installing older versions and checking that everything still works! |
The version dependency makes it hard to install nbextensions on certain
platforms (e.g. ARM). See Issue #1172.