Undefined title_sidebar

[jfbercher]

In some "old" exported html files, with toc2 embedded, the cfg.title_sidebar is not defined; This tests for the cfg key and define it if necessary (Otherwise the sidebar title appears as "undefined")

[jcb91]

This (along with all metadata values) should already have a default value in the newest version? Is that not working correctly?

[jfbercher]

Yes, with current version and conversions, but already converted notebooks do not have all variables defined. See eg this example.

Of course I can easily update my own files (I have a bunch of lectures in ipynb/html formats), but there can be some other floating in the web.

[jcb91]

Oh, I'm all for having defaults! I just thought that this (and similar issues) would be handled by 1972313, but it seems I forgot that the read_config method which defines the defaults isn't called in non-live notebooks 😞.

I've pushed a commit which should ensure defaults are set for all config values...

[jcb91]

Seems to work for the title :)

[jfbercher]

Well done!