[toc2] only set notebook dirty if metadata item changed#1178
Merged
jcb91 merged 1 commit intoipython-contrib:masterfrom Dec 19, 2017
Merged
[toc2] only set notebook dirty if metadata item changed#1178jcb91 merged 1 commit intoipython-contrib:masterfrom
jcb91 merged 1 commit intoipython-contrib:masterfrom
Conversation
ToC setting the notebook dirty every time it loaded was annoying me. This uses deep compare if underscore is available. In other cases, the shallow compare means object like toc_position will always look changed, but that's ok, as it only gets set when something gets moved anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToC setting the notebook dirty every time it loaded was annoying me.
This uses deep compare if underscore is available.
In other cases, the shallow compare means object like toc_position will
always look changed, but that's ok, as it only gets set when something
gets moved anyway.