Skip to content

Use base_url in snippets#1212

Merged
jcb91 merged 2 commits intoipython-contrib:masterfrom
juhasch:fix/snippets
Feb 1, 2018
Merged

Use base_url in snippets#1212
jcb91 merged 2 commits intoipython-contrib:masterfrom
juhasch:fix/snippets

Conversation

@juhasch
Copy link
Copy Markdown
Member

@juhasch juhasch commented Jan 28, 2018

Fixes issue #1210

@jcb91
Copy link
Copy Markdown
Member

jcb91 commented Jan 30, 2018

Good job catching this @juhasch :)

For full generality (e.g. someone at some point renames snippets directory, puts it in a subdirectory, etc), we could add 'require' to the requirements list, then use a relative path like requirejs.toUrl('./snippets.json')

But I think this version is fine here, since we don't add any instructions for separate installs anyway.

@jcb91 jcb91 merged commit cd14861 into ipython-contrib:master Feb 1, 2018
@juhasch
Copy link
Copy Markdown
Member Author

juhasch commented Feb 2, 2018

Thanks.

@juhasch juhasch deleted the fix/snippets branch February 25, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants