[toc2] Initialize toc2 button after cfg is loaded / fix #1249#1250
Merged
jfbercher merged 2 commits intoipython-contrib:masterfrom Mar 19, 2018
Merged
[toc2] Initialize toc2 button after cfg is loaded / fix #1249#1250jfbercher merged 2 commits intoipython-contrib:masterfrom
jfbercher merged 2 commits intoipython-contrib:masterfrom
Conversation
also use local Jupyter variable rather than global
Member
Author
|
Let's give a try to this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentative fix for #1249.
Initialize
toc_button(cfg)only after cfg has been defined (perhaps not read yet (?), but defined). Otherwise, the handler intoc_buttonpoints to an undefined object.