Skip to content

Remove OSX travis run#1253

Merged
juhasch merged 1 commit intoipython-contrib:masterfrom
juhasch:fix/travis
Feb 25, 2018
Merged

Remove OSX travis run#1253
juhasch merged 1 commit intoipython-contrib:masterfrom
juhasch:fix/travis

Conversation

@juhasch
Copy link
Copy Markdown
Member

@juhasch juhasch commented Feb 25, 2018

No description provided.

@jcb91
Copy link
Copy Markdown
Member

jcb91 commented Feb 25, 2018

👍

@juhasch juhasch merged commit edd5701 into ipython-contrib:master Feb 25, 2018
@juhasch juhasch deleted the fix/travis branch February 25, 2018 13:52
@josephcslater
Copy link
Copy Markdown

josephcslater commented Mar 7, 2018

Does this mean there will no longer be OSX support?

@jcb91
Copy link
Copy Markdown
Member

jcb91 commented Mar 7, 2018

Does this mean there will no longer be OSX support?

No, OSX is similar enough to linux that the CI builds there are pretty much sufficient.

The main issue here was that our OSX Travis runs were slow to start, and were running into problems with the initial python setup, which was causing PRs to look like they had breaking changes all the time, when in reality they didn't. Since we don't have object libraries, and most of our file-location stuff is handled by jupyter_core, we don't have much in the way of platform-dependent code anyway. However, it would be nice to re-add OSX runs eventually, even if only for the added peace of mind.

Hope that makes sense?

@josephcslater
Copy link
Copy Markdown

josephcslater commented Mar 7, 2018

Perfect. As you know from my recent issue... I have one that I can't trace and am hoping it's figured out eventually (or my system inexplicably continues to work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juhasch @jcb91 @josephcslater
⚡