Skip to content

Fixed collapsible_headings key conflict #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcb91 merged 2 commits into from
Mar 17, 2018
Merged

Fixed collapsible_headings key conflict #1264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e5f936
Changed keyboard patches to use jupyter event directly, rather than q…
rhilenova Mar 15, 2018
465ec3c
Updating changelog.
rhilenova Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ New features and bugfixes:
- Add preprocessor to embed images into a notebook
[#1067](https://github.com/ipython-contrib/jupyter_contrib_nbextensions/pull/1067)
[@juhasch](https://github.com/juhasch)
- Fixed conflicts in collapsible_headings if keys are rebound.
[@rhilenova](https://github.com/rhilenova)


0.4.0
Expand Down
4 changes: 2 additions & 2 deletions src/jupyter_contrib_nbextensions/nbextensions/collapsible_headings/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@

var kbm = Jupyter.keyboard_manager;

var action_up = kbm.actions.get(kbm.command_shortcuts.get_shortcut('up'));
var action_up = kbm.actions.get("jupyter-notebook:select-previous-cell");
var orig_up_handler = action_up.handler;
action_up.handler = function (env) {
for (var index = env.notebook.get_selected_index() - 1; (index !== null) && (index >= 0); index--) {
Expand All @@ -647,7 +647,7 @@
return orig_up_handler.apply(this, arguments);
};

var action_down = kbm.actions.get(kbm.command_shortcuts.get_shortcut('down'));
var action_down = kbm.actions.get("jupyter-notebook:select-next-cell");
var orig_down_handler = action_down.handler;
action_down.handler = function (env) {
var ncells = env.notebook.ncells();
Expand Down
⚡