Skip to content

Long labels in code_prettify/2to3#1268

Merged
jcb91 merged 3 commits intoipython-contrib:masterfrom
jfbercher:koc
Mar 20, 2018
Merged

Long labels in code_prettify/2to3#1268
jcb91 merged 3 commits intoipython-contrib:masterfrom
jfbercher:koc

Conversation

@jfbercher
Copy link
Copy Markdown
Member

And others derived from kernel_exec_on_cells.

Remove the label from the add_buttons_group and add it back "by hand" to enable the bubble help.
Fixes #1243 (shift-clik works for me) and last comment in #1102.

@jcb91
Copy link
Copy Markdown
Member

jcb91 commented Mar 20, 2018

Thanks @jfbercher. Is the space trick really necessary? label can't be undefined, or an empty string?

@jfbercher
Copy link
Copy Markdown
Member Author

@jcb91. It seems necessary. Unfortunately, both label: '' and label: undefined fail with kernel_exec_on_cell.js?v=20180320174230:344 [code_prettify] error loading: TypeError: Cannot read property 'help' of undefined at toolbar.js:97. I haven't investigated what happens in toolbar.js

@jcb91
Copy link
Copy Markdown
Member

jcb91 commented Mar 20, 2018

Ok, good enough for me :)

@jcb91 jcb91 merged commit db0fccc into ipython-contrib:master Mar 20, 2018
@jfbercher jfbercher deleted the koc branch March 21, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants