Configurable github endpoint to support publishing gists to Github Enterprise#1364
Merged
juhasch merged 1 commit intoipython-contrib:masterfrom Dec 31, 2018
Merged
Conversation
shiti-saxena
changed the title
Contributor
Author
|
@jcb91 do you think this might be useful? |
shiti-saxena
changed the title
Member
|
Thank you. Looks good to me. |
|
While helpful, this is not quite configurable enough in my case. The url for the gist api on github.com itself is https://api.github.com/gists/. However, my company's enterprise server uses the format https://hostname/api/v3/gists/. According to https://developer.github.com/enterprise/2.16/v3/enterprise-admin/, this is the default enterprise configuration. It would be great if the configuration allowed for this kind of flexibility instead of only customizing the host name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an additional property
github_endpointwhich will be used to publish gists. If not set, the endpoint ishttps://github.com