Update Navigation HotKeys Extension to work with command palette on new versions of jupyter #1378
Merged
juhasch merged 4 commits intoipython-contrib:masterfrom Dec 29, 2018
Conversation
JSpenced
changed the title
Contributor
Author
|
The last commit makes it completely backwards compatible plus adds in so you can toggle some of the settings on and off to fix request #1334 . |
JSpenced
force-pushed
the
update-for-jupyter-and-remove-redundant-keys
branch
from
ed713eb to
e8c55e9
Compare
JSpenced
force-pushed
the
update-for-jupyter-and-remove-redundant-keys
branch
from
e8c55e9 to
51fb117
Compare
Member
|
Thank you for your contribution. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates so it doesn't use
Ipython.anymore and the newactions.registerandadd_shortcutcommands.If you use this in the most recent versions of jupyter, it loads the functions improperly like this:
This has been fixed to have a proper group called
navigation_hotkeys.Also, second commit I removed two functions because those functions are already implemented in Jupyter as default bindings. They can be set in your
notebook.jsonfile, which I think is better.#1334 Also solves this problem as this was one of the removed default bindings.