[toc2] fix for disappearing sidebar in static html_toc export#1548
Merged
juhasch merged 1 commit intoipython-contrib:masterfrom Apr 5, 2021
Merged
Conversation
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue i had w/ static html dumps of notebooks (w/ the toc2 sidebar) - where the table of contents sidebar would disappear (#1547)
problem was that the sidebar top position was getting set to scroll position, but the css must have set it to a fixed position or something - so it should have been
0tested my static notebook dump in firefox and chrome -worked in both - also tested the dynamic sidebar in chrome
someone who knows more about the repo should look over this b/c I dont know anything about webdev (or this repo)
also - linked issue: #1547