Fix limit output missing braces#784
Merged
jcb91 merged 1 commit intoipython-contrib:masterfrom Nov 1, 2016
Merged
Conversation
Due to the currently mismatching braces, the limit output extension will usually display an error message indicating it is limiting output, although it is not (but not indicating such in console.log). Fixed this bug and also added ability to display the current and maximum output lengths in the error message to make this type of error easier to debug in future. Change-Id: Ib806f011fc4919d1a1b6279c9e37e4564d12bbed
Member
|
Good spot, thanks! Obvious once it's pointed out haha 😜 |
Member
|
Thanks for spotting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are missing braces causing the indentation to not match the code flow. Due to the currently mismatching braces, the limit output extension will usually display an error message indicating it is limiting output, although it is not (but not indicating such in console.log).
Fixed this bug and also added ability to display the current and maximum output lengths in the error message to make this type of error easier to debug in future.