Freeze uses cell.metadata.editable to support 4.x and 5.x Jupyter notebooks.#968
Merged
jcb91 merged 4 commits intoipython-contrib:masterfrom Apr 22, 2017
Merged
Conversation
…ol.read_only. This version reads old format metadata and replaces it by new format metadata (for Freeze).
Contributor
Author
|
New pull request for #940. Apologies if this makes things confusing, but it was easier and faster for me to just create a new branch and pull request. |
also more aggressive removal of redundant metadata
Member
|
Sure, no problem, it's certainly simpler from scratch in this case! This looks mainly good, but I've a few changes to add that I'll PR to your fork |
mainly semicolons
[Freeze] alterations to 5.x update
Member
|
Thanks @tnarik! |
This was referenced Apr 22, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Freeze uses cell.metadata.editable instead of cell.metadata.run_control.read_only.
This version reads old format metadata and replaces it by new format metadata (for Freeze).