Skip to content

[Freeze] Fix property checking #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcb91 merged 2 commits into from
Apr 25, 2017
Merged

[Freeze] Fix property checking #976

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
face129
[Freeze] Fix migrating read_only properties
yacchin1205 Apr 24, 2017
7f6adac
[Freeze] Fix TypeError when run_control is missing
yacchin1205 Apr 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/jupyter_contrib_nbextensions/nbextensions/freeze/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ define([
function migrate_state (cell) {
if (cell.metadata.run_control !== undefined) {
if (cell instanceof CodeCell || cell instanceof MarkdownCell) {
cell.metadata.editable = !cell.metadata.run_control.read_only;
if (cell.metadata.run_control.read_only === true) {
cell.metadata.editable = false;
}
}
else {
// remove metadata irrelevant to non-code/markdown cells
Expand Down Expand Up @@ -110,7 +112,7 @@ define([
break;
}
// remove whole object if it's now empty
if (Object.keys(cell.metadata.run_control).length === 0) {
if (cell.metadata.run_control !== undefined && Object.keys(cell.metadata.run_control).length === 0) {
delete cell.metadata.run_control;
}
cell.code_mirror.setOption('readOnly', !cell.metadata.editable);
Expand Down
⚡