Skip to content

[init_cell] fix typo in options-loading code #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcb91 merged 1 commit into from
May 15, 2017
Merged

[init_cell] fix typo in options-loading code #987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/jupyter_contrib_nbextensions/nbextensions/init_cell/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ define([
}
},
function getter (cell) {
// if init_cell is undefined, it'll be interpreted as false anyway
// if init_cell is undefined, it'll be interpreted as false anyway
return cell.metadata.init_cell;
}
);
Expand Down Expand Up @@ -72,7 +72,7 @@ define([
// setup things to run on loading config/notebook
Jupyter.notebook.config.loaded
.then(function update_options_from_config () {
$.extend(true, options, Jupyter.notebook.config[mod_name]);
$.extend(true, options, Jupyter.notebook.config.data[mod_name]);
}, function (reason) {
console.warn(log_prefix, 'error loading config:', reason);
})
Expand All @@ -85,7 +85,7 @@ define([
console.error(log_prefix, 'unhandled error:', reason);
});
};

function callback_notebook_loaded () {
// update from metadata
var md_opts = Jupyter.notebook.metadata[mod_name];
Expand Down
⚡