Conversation
isaacs
changed the title
isaacs
force-pushed
the
handle-eisdir
branch
2 times, most recently
from
f318a5e to
ee47a66
Compare
These tests depend on being able to lchown a symbolic link to /bin/sh, and rely on the assumption that /bin/sh is not owned by the current user. The first assumption will typically fail on Linux whenever the second assumption is true! Fixing the first, by linking to a local file instead, means that the second is violated. There is no way to save these tests, so they are being removed.
isaacs
added a commit
to npm/cli
that referenced
this pull request
Jul 3, 2019
This handles an EISDIR error from cacache on Darwin in Node versions prior to 10.6. Fix: [npm.community#7901](https://npm.community/t/7901/) Fix: [npm.community#8203](https://npm.community/t/8203/) Fix: isaacs/chownr#20 PR-URL: isaacs/chownr#21
This was referenced Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #20