Skip to content

chore(scaffold): install tfskel via install.sh in reusable workflow#104

Merged
ishuar merged 1 commit intomainfrom
chore/tfskel-install-script
May 6, 2026
Merged

chore(scaffold): install tfskel via install.sh in reusable workflow#104
ishuar merged 1 commit intomainfrom
chore/tfskel-install-script

Conversation

@ishuar
Copy link
Copy Markdown
Owner

@ishuar ishuar commented May 6, 2026

What and why

Switches the reusable Terraform plan/apply workflow to install tfskel via the repo's install.sh script instead of go install.

  • Removes the actions/setup-go step (no Go toolchain needed on the runner anymore).
  • Replaces go install github.com/ishuar/tfskel@<version> with a curl ... | bash invocation of install.sh, passing TFSKEL_VERSION / INSTALL_DIR via env.
  • latest maps to the script's default by unsetting TFSKEL_VERSION before the curl pipe.

Behavior is unchanged from the caller's perspective: the same inputs.tfskel_version is honored, and tfskel review plan runs the same way.

Fixes #

Notes for reviewers

  • Pure mechanism change for installing tfskel — no new functionality.
  • Only the reusable workflow template under internal/templates/files/github/ is touched.

Replaces the `actions/setup-go` + `go install` pair with a curl pipe to
the repo's install.sh. Drops the Go toolchain provisioning step entirely,
shrinking the plan job. Behavior is unchanged: the same tfskel version
selected by `inputs.tfskel_version` is installed (with `latest` mapping
to the script's default by unsetting TFSKEL_VERSION).
@ishuar ishuar merged commit 3c19128 into main May 6, 2026
3 checks passed
@ishuar ishuar deleted the chore/tfskel-install-script branch May 6, 2026 12:00
ishuar pushed a commit that referenced this pull request May 6, 2026
🤖 I have created a release *beep* *boop*
---


## [0.8.4](v0.8.3...v0.8.4)
(2026-05-06)


### ✨ Features

* **scaffold:** add terraform_extra_secrets input to reusable workflow
([#103](#103))
([1cfcd13](1cfcd13))


### 📦 Other Changes

* extract version line via grep in install success message
([#101](#101))
([7465753](7465753))
* **scaffold:** install tfskel via install.sh in reusable workflow
([#104](#104))
([3c19128](3c19128))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant