Skip to content

chore: add Node.js 8 and 10, remove Node.js 4#829

Merged
bcoe merged 3 commits intoistanbuljs:masterfrom
DanielRuf:chore/add-nodejs-8-remove-nodejs-4
May 8, 2018
Merged

chore: add Node.js 8 and 10, remove Node.js 4#829
bcoe merged 3 commits intoistanbuljs:masterfrom
DanielRuf:chore/add-nodejs-8-remove-nodejs-4

Conversation

@DanielRuf
Copy link
Copy Markdown
Contributor

Node.js 4 is EOL since last month.

@bcoe
Copy link
Copy Markdown
Member

bcoe commented May 8, 2018

@DanielRuf please go ahead and add "8", but let's wait to remove "4" until we decide we want to bump the major -- otherwise there's a danger of landing breaking changes accidentally.

@DanielRuf
Copy link
Copy Markdown
Contributor Author

@DanielRuf please go ahead and add "8", but let's wait to remove "4" until we decide we want to bump the major -- otherwise there's a danger of landing breaking changes accidentally.

Done

@bcoe bcoe merged commit a522dd9 into istanbuljs:master May 8, 2018
@DanielRuf DanielRuf deleted the chore/add-nodejs-8-remove-nodejs-4 branch May 8, 2018 22:19
dhui added a commit to dhui/node-http-link-header that referenced this pull request Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants