Skip to content

feat: allow a custom storagePath#56

Merged
bcoe merged 1 commit intoistanbuljs:masterfrom
mvegter:feature/configurable-storagePath
Jun 11, 2020
Merged

feat: allow a custom storagePath#56
bcoe merged 1 commit intoistanbuljs:masterfrom
mvegter:feature/configurable-storagePath

Conversation

@mvegter
Copy link
Copy Markdown
Contributor

@mvegter mvegter commented May 31, 2020

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented May 31, 2020

Pull Request Test Coverage Report for Build 156

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 151: 0.0%
Covered Lines: 221
Relevant Lines: 221

💛 - Coveralls

@mvegter mvegter force-pushed the feature/configurable-storagePath branch 2 times, most recently from 48db9dd to cf82cfa Compare May 31, 2020 21:02
@mvegter mvegter force-pushed the feature/configurable-storagePath branch from cf82cfa to 6a56b48 Compare May 31, 2020 21:11
@mvegter
Copy link
Copy Markdown
Contributor Author

mvegter commented Jun 9, 2020

Hi @bcoe, do you have any feedback on this (and/or possibly #57)?

@bcoe bcoe merged commit eb1aabc into istanbuljs:master Jun 11, 2020
@bcoe
Copy link
Copy Markdown
Member

bcoe commented Jun 11, 2020

@mvegter this looks quite reasonable to me 👍 thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants