Fix scrollend event not being fired in some cases#270
Open
jabberfest wants to merge 3 commits intojamesflorentino:masterfrom
Open
Fix scrollend event not being fired in some cases#270jabberfest wants to merge 3 commits intojamesflorentino:masterfrom
jabberfest wants to merge 3 commits intojamesflorentino:masterfrom
Conversation
Author
|
See: https://developer.mozilla.org/en-US/docs/Web/API/Element.scrollHeight The following will get you subpixel values for scrollHeight and clientHeight but it only works on IE9+. @jamesflorentino, @kristerkari any thoughts? element.getBoundingClientRect() |
Collaborator
|
@jabberfest Thanks! I'll have to test this in different browsers to verify the fix. |
Author
|
I just realized that my approach breaks the scroll event that fires when the scroll bar is at the beginning. this is due to me just adding a 1 pixel offset |
Collaborator
|
Oh yeah true, then we need to think about an alternative solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain cases the "scrollend" event is never fired. Chrome and Firefox rounds values down for scrollTop.
In some cases contentScrollTop is one less than maxScroll top despite being scrolled all the way down.