Fix for unhandled promise rejections in Jest tests#80
Merged
jamiebuilds merged 1 commit intojamiebuilds:masterfrom Nov 27, 2017
Merged
Fix for unhandled promise rejections in Jest tests#80jamiebuilds merged 1 commit intojamiebuilds:masterfrom
jamiebuilds merged 1 commit intojamiebuilds:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, thanks for this library.
Since Jest v21.0.0, there is an
unhandledRejectionhandler that will fail tests that don't handle promise rejections.Loadableleaves an unhandled promise rejection when theloaderpromise is rejected and consequently the test fails. This makes cases where the error case is expected impossible to test.This change stops throwing
errin thecatchof the promise, so the promise rejection is handled.I believe this is not an issue as the promise is not returned and therefore cannot be chained onto, making the rejection unnecessary in the first place.