Fix stale fiber stack pointers across realloc#1751
Merged
Conversation
Those cached pointers are not safe to use across Janet fiber operations, which may reallocate and invalidate those pointers. Use the fields directly.
Member
|
Looks good to me! Thanks for the work here, as well as in #1750. I recently fixed similar issues in various places in vm.c, but I suppose we missed some. janet_eprintf and family did not used to be able to modify the stack, so the vm code overlooked it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those cached pointers are not safe to use across Janet fiber operations, which may reallocate and invalidate those pointers.
Use the fields directly.
This fixes #1750 as well as one more location where stale
fiber->datais used from my audit.Codex was used to assist me in finding the invocations and flags to build and run Janet tests with ASAN, but the proposed fixes are all mine.