Skip to content

Fix documentation for os_stat function#1760

Merged
bakpakin merged 2 commits into
janet-lang:masterfrom
taoeffect:patch-1
Jun 10, 2026
Merged

Fix documentation for os_stat function#1760
bakpakin merged 2 commits into
janet-lang:masterfrom
taoeffect:patch-1

Conversation

@taoeffect

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 8, 2026 19:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the os/stat core function documentation to clarify return behavior when an optional keyword argument is provided.

Changes:

  • Adjusted the os/stat docstring wording for clearer return semantics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/core/os.c Outdated
@sogaiu

sogaiu commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

The suggested change seems like an improvement to me, though I agree with the basic idea suggested by the review comment as well.

@taoeffect

Copy link
Copy Markdown
Contributor Author

Pushed.

@sogaiu

sogaiu commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

LGTM

@bakpakin bakpakin merged commit 004c0b0 into janet-lang:master Jun 10, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants